Skip to content

test: split test-runner-output #60330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2025
Merged

test: split test-runner-output #60330

merged 3 commits into from
Oct 24, 2025
+1,024 −358

Conversation

@joyeecheung
Copy link
Member

This test has been flaky for months. As it squeezes too many
independent test cases together in one file, split this up
before marking any persistent flaky cases as flaky, to avoid
masking regressions in other non-flaky cases.

Refs: #55390

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 20, 2025
@joyeecheung
test: split test-runner-output
72e2782 
This test has been flaky for months. As it squeezes too many
independent test cases together in one file, split this up
before marking any persistent flaky cases as flaky, to avoid
masking regressions in other non-flaky cases.
@joyeecheung joyeecheung force-pushed the split-test-runner-output branch from 9333d0c to 72e2782 Compare October 20, 2025 23:54
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (2fb82c8) to head (f668271).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60330      +/-   ##
==========================================
- Coverage   88.59%   88.59%   -0.01%     
==========================================
  Files         704      704              
  Lines      208474   208398      -76     
  Branches    40067    40063       -4     
==========================================
- Hits       184696   184625      -71     
+ Misses      15805    15801       -4     
+ Partials     7973     7972       -1

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69844/

atlowChemi
atlowChemi approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@atlowChemi atlowChemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all the tests really need to have --expose-internals?

lpinca
lpinca approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@joyeecheung
Copy link
Member Author

Do all the tests really need to have --expose-internals?

Thanks for catching it, I've updated the tests that don't do canColorize() to remove that flag. PTAL.

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69865/

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit bfcf2f7 into nodejs:main Oct 24, 2025
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bfcf2f7

aduh95 pushed a commit that referenced this pull request Oct 26, 2025
@joyeecheung @aduh95
test: put helper in test-runner-output into common
0b38de3 
PR-URL: #60330
Refs: #55390
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@pmarchini pmarchini pmarchini approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung @nodejs-github-bot @lpinca @MoLow @pmarchini @atlowChemi