Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 4, 2016

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

doc build arm

Description of change

Android is not supported at this time, so let's make sure people know that before they get too far.

Refs: #6035

@Trott Trott added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM platform. labels Apr 4, 2016
@Trott Trott force-pushed the not-supported branch 2 times, most recently from f5d36fc to 7a2c3bd Compare April 4, 2016 17:55
BUILDING.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small nit, but perhaps it should say is not an officially supported platform?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscdex I agree with your nit. Updating now...

@cjihrig
Copy link
Contributor

cjihrig commented Apr 4, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Apr 4, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Apr 5, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2016
PR-URL: nodejs#6040
Refs: nodejs#6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 6, 2016

Landed in 0f3c3b4

@Trott Trott closed this Apr 6, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
This was referenced Apr 21, 2016
@Trott Trott deleted the not-supported branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants