Skip to content

Conversation

suryagh
Copy link
Contributor

@suryagh suryagh commented May 5, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

if the valid ca is the first item within the concatenated string
then the bug addressed by #4099 was not getting exposed. This test
makes sure the order of valid ca should not effect the expected
behaviour when multiple ca certs are concatenated.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 5, 2016
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label May 5, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the whitespace changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

if the valid `ca` is the first item within the concatinated string
then the bug addressed by nodejs#4099 was not getting exposed. This test
makes sure the order of valid `ca` should not effect the expected
behavior when multiple `ca` certs are concatinated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants