doc: clarify fs.mkdtemp prefix argument #6800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per: nodejs#6142 Clarify the prefix argument. Fixes: nodejs#6142
jasnell
added
doc
Member
|
LGTM |
doc/api/fs.md
Outdated
|
|
||
| ```js | ||
| // The parent directory for the new temporary directory | ||
| const tmp_dir = '/tmp'; |
Contributor
There was a problem hiding this comment.
we follow camel casing for js variables, right?
Member
Author
|
@thefourtheye ... nits fixed. |
Contributor
|
LGTM |
jasnell
added a commit
that referenced
this pull request
May 18, 2016
Per: #6142 Clarify the prefix argument. Fixes: #6142 PR-URL: #6800 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Member
Author
|
Landed in 2ccba1f |
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
Per: #6142 Clarify the prefix argument. Fixes: #6142 PR-URL: #6800 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Per: #6142 Clarify the prefix argument. Fixes: #6142 PR-URL: #6800 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc (fs)
Description of change
Per: #6142
Clarify the
prefixargument.@nodejs/fs @nodejs/documentation