Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented May 26, 2016

Checklist
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Change The in the middle of a sentence to the. Wrap text at 80 chars

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 26, 2016
by consumers of Readable streams.**

If a value other than null is passed, The `push()` method adds a chunk of data
If a value other than null is passed, the `push()` method adds a chunk of data
Copy link
Contributor

@MylesBorins MylesBorins May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure? I see a comma there...

edit: I read the diff backwards... my fault

LGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to figure out if you were trolling me or not.

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label May 26, 2016
@eljefedelrodeodeljefe
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented May 26, 2016

@Trott ... can we fold this into #6947?

@jasnell
Copy link
Member

jasnell commented May 26, 2016

Actually... double checking on this, I've already covered this in #6947

@Trott
Copy link
Member Author

Trott commented May 27, 2016

Actually... double checking on this, I've already covered this in #6947

Closing in favor of #6947.

@Trott Trott closed this May 27, 2016
@Trott Trott deleted the trivial-typo branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants