benchmark: fix hanging test client-request-body #7463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this benchmark does not close the server it creates and continues sending requests to the server after the benchmark has completed. This causes the benchmark to hang. This change cleans up the server and stops the sending of requests after the benchmark has completed.
nodejs-github-bot
added
the
benchmark
|
Actually, #7311 will fix this when it lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
Currently, this benchmark does not close the server it creates and
continues sending requests to the server after the benchmark has
completed. This causes the benchmark to hang.
This change cleans up the server and stops the sending of requests after
the benchmark has completed.