build: reduces unused js2c.py code #7465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likely those parts originate from the single commit 63a9cd3 and have never been used. This cleans up some of the implementation to have less confusions for devs visiting this file.
mscdex
added
build
|
cc @nodejs/build @bnoordhuis @indutny |
|
CI is green. |
|
LGTM |
|
cc @bnoordhuis |
|
LGTM but s/reduces/reduce/ (or 'remove' or 'delete') and s/likely/Likely/ in the commit log. |
|
LGTM if it works (with @bnoordhuis's nits). Also, it looks like the commit message may have long line but I may be wrong. |
| output.write(HEADER_TEMPLATE % { | ||
| 'builtin_count': len(ids) + len(delay_ids), | ||
| 'delay_count': len(delay_ids), | ||
| 'source_lines': "\n".join(source_lines_empty), |
There was a problem hiding this comment.
Remove the declaration and accumulation of source_lines_empty as well. It is not used anywhere else.
|
I don't want to steal your thunder but I was going through my open pull requests and I realized I made pretty much the same changes in #5458. |
|
Fine for me. :) closing in favour for #5458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passestests and/or benchmarks are includeddocumentation is changed or addedAffected core subsystem(s)
buildDescription of change
Just for housekeeping and less confusion, we could get rid of unused code in
js2c.py. I didn't see any use of those parts at least and can originate it back to commit 63a9cd3I dug into this part of the build process and wanted to rewrite
js2c.pyin JS, which is fairly trivial now, as opposed to 2009. But those parts are just not necessary - pending CI.