Fix tty tests #7613
Merged
Fix tty tests #7613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
test
|
LGTM. CI is green. |
Refs: nodejs#7360 PR-URL: nodejs#7613 Reviewed-By: Colin Ihrig <[email protected]>
test-tty-wrap hasn’t worked since StreamBase was introduced, I think. test-tty-stdout-end also happens to works with PipeWrap-s. Refs: nodejs#7360 PR-URL: nodejs#7613 Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123
force-pushed
the
fix-tty-tests
branch
from
abb6fe8 to
aab3066
Compare
|
@Fishrock123 lts? |
|
@thealphanerd You'd also need to backport 88804b8 The test should pass. Maybe that entire PR should be backported? unsure |
evanlucas
pushed a commit
that referenced
this pull request
Jul 15, 2016
Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jul 15, 2016
test-tty-wrap hasn’t worked since StreamBase was introduced, I think. test-tty-stdout-end also happens to works with PipeWrap-s. Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
3 tasks
|
@Fishrock123 this is not landing cleanly on v4.x-staging |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
test-tty-wrap hasn’t worked since StreamBase was introduced, I think. test-tty-stdout-end also happens to works with PipeWrap-s. Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
test-tty-wrap hasn’t worked since StreamBase was introduced, I think. test-tty-stdout-end also happens to works with PipeWrap-s. Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
test-tty-wrap hasn’t worked since StreamBase was introduced, I think. test-tty-stdout-end also happens to works with PipeWrap-s. Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
test-tty-wrap hasn’t worked since StreamBase was introduced, I think. test-tty-stdout-end also happens to works with PipeWrap-s. Refs: #7360 PR-URL: #7613 Reviewed-By: Colin Ihrig <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, tty
Description of change
Found these while investigating #7360.
Turns out
test-tty-wrap.jshasn't worked for over a year.test-tty-stdout-end.jsworks because the same functionality just so happens to also exist onPipeWraps.Commit 1 is to preserve the file history correctly.
CI: https://ci.nodejs.org/job/node-test-pull-request/3219/
R: @nodejs/testing I suppose