doc: correct crypto encoding information #7805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of binary.
nodejs-github-bot
added
crypto
|
LGTM |
|
cc @nodejs/crypto |
|
Do we have a test for this? |
|
LGTM |
|
ping @nodejs/crypto |
jasnell
pushed a commit
that referenced
this pull request
Aug 4, 2016
The default encoding for crypto methods was changed in v6.0.0 with v4.x keeping a default of binary. PR-URL: #7805 Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 561958e! |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
The default encoding for crypto methods was changed in v6.0.0 with v4.x keeping a default of binary. PR-URL: #7805 Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of binary.
Ref: b010c87