Skip to content

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 2, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

Cherry-pick of process: fix handling of process.noDeprecation in emitWarning from:

PR-URL: #8166
Reviewed-By: Сковорода Никита Андреевич [email protected]
Reviewed-By: Myles Borins [email protected]

Cherry-picked from:
  PR-URL: nodejs#8166
  Reviewed-By: Сковорода Никита Андреевич <[email protected]>
  Reviewed-By: Myles Borins <[email protected]>
@jasnell jasnell added process Issues and PRs related to the process subsystem. v6.x labels Sep 2, 2016
@jasnell
Copy link
Member Author

jasnell commented Sep 7, 2016

@thealphanerd @ChALkeR ... PTAL
@Fishrock123 ... this commit landed in master, it should be pulled back to v6.x also. The other commits in the original PR should not be pulled back, however.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this should probably target v6.x-staging now?

@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2016

Agreed.

@jasnell jasnell changed the base branch from v6.x to v6.x-staging September 26, 2016 15:00
@jasnell
Copy link
Member Author

jasnell commented Sep 26, 2016

Landed in e097a50.

@jasnell jasnell closed this Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants