win,build: improvements to vcbuild.bat #8412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
added
windows
|
LGTM |
joaocgreis
added a commit
that referenced
this pull request
Sep 8, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
joaocgreis
added a commit
that referenced
this pull request
Sep 8, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
joaocgreis
added a commit
that referenced
this pull request
Sep 8, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
|
CI: https://ci.nodejs.org/job/node-test-pull-request/3957/ Landed in 292168e, b57c962 and 446c9cd. Thanks! |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
|
@joaocgreis should this be backported? |
|
@thealphanerd yes, I think all of this would also be helpful in v4. Thanks! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8412 Reviewed-By: Ben Noordhuis <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Windows, Build.
Description of change
This PR includes 3 changes to
vcbuild.bat:vcbuild.bat. Before there was only a warning, and since the output is quite verbose it was very easy to miss it and vcbuild would run without the options that the user probably wanted.msbuildand other Visual Studio tools are not needed, do not search for Visual Studio. This allows for running the tests in a machine with an unsupported version of VS, or no VS at all. This unblocks src: remove VS 2013 compatibility hacks #8067 , since for v6 onwards we want to build node only with VS2015 but still want to run the tests in machines with VS2013 (node-gyp will detect it independently).I think the commits should not be squashed because they address different concerns, but I can squash if this is not consensual.
cc @nodejs/platform-windows