child_process: remove unreachable execSync() code #9209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
jasnell
approved these changes
Oct 20, 2016
targos
approved these changes
Oct 20, 2016
lpinca
approved these changes
Oct 20, 2016
thefourtheye
approved these changes
Oct 21, 2016
|
CI: https://ci.nodejs.org/job/node-test-pull-request/4656/ The failures appear to be unrelated. |
Code coverage showed that the execSync() variable inheritStderr was never set to the default value of true. This is because the default case is hit whenever normalizeExecArgs() returns an object without an 'options' property. However, this can never be the case because normalizeExecArgs() unconditionally creates the options object. This commit removes the unreachable code. PR-URL: nodejs#9209 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
@cjihrig should this be backported to v4 and v6? |
|
v6, yes. v4, no. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
child_process
Description of change
Code coverage showed that the
execSync()variableinheritStderrwas never set to the default value oftrue. This is because the default case is hit whenevernormalizeExecArgs()returns an object without anoptionsproperty. However, this can never be the case becausenormalizeExecArgs()unconditionally creates theoptionsobject. This commit removes the unreachable code.