Skip to content

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Oct 27, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

as in title

@jasnell - another one to include in the port

/cc @nodejs/ctc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 27, 2016
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly only reviewed statements attributed to me, but LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: till -> until

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: bad, choosing -> bad. Choosing

PR-URL: nodejs#9326
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@joshgav
Copy link
Contributor Author

joshgav commented Oct 31, 2016

landed in feb3531

@joshgav joshgav merged commit feb3531 into nodejs:master Oct 31, 2016
@joshgav joshgav deleted the ctc-2016-10-05 branch November 1, 2016 15:44
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
PR-URL: #9326
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9326
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9326
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants