-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
doc: add guide for maintaining V8 #9777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"now the broweser" should be "not the browser"
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
authors? people to ask for help? something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was authors, but I have removed that line.
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"If the" -> "The"?
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this different from backporting to active branches? doesn't v8 backport to active?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to clarify this a bit further. The idea was that there are three classes of bugs, Node.js bugs that have (1) or have not (2) been fixed upstream, and bugs that have not been encountered by Node.js yet but upstream has identified as potentially interesting to Node (3).
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this branch? I don't see it in nodejs/node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added link. FYI, it is at https://github.com/v8/node/tree/vee-eight-lkgr but we can bring this over to nodejs/node too if it is helpful.
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"into V8 5.1"
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v6.x-staging is just an example, right? because backports might be necessary to any LTS staging branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified.
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trace_event, or trace_event.h?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trace event is a component. gtest_prod.h is just a file.
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after V8 5.4 shipped as stable.
0983c42
to
f07f5c2
Compare
I will land this later today. |
Thanks. Landed as 11b0872. |
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]>
Checklist
Affected core subsystem(s)
doc
Description of change
This document attempts to describe the processes for maintaining the V8 brances in Node.js LTS and Current releases.
Previously: nodejs/Release#137