dist-indexer: fix libuv version generation #6
Conversation
Beginning in nodejs/node@537a4ba, `deps/uv/include/uv-version.h` moved to `deps/uv/include/uv/version.h`, so add that as a possible path where libuv's version might be stored. Refs: nodejs/node#21466
|
Once this has been approved, a release has been published to npm, and the new package has been installed on the web server, the following command should be run through the |
dist-indexer.js
Outdated
| } | ||
| }) | ||
|
|
||
| fetch(uvVersionUrl[3], gitref, function (err, rawData) { |
There was a problem hiding this comment.
I think you're going to need to nest this inside the previous fetch() otherwise it's going to run in parallel and likely conflict. i.e. indent all of this plus the two lines below it by 2 spaces and move the }) just above here down to the bottom
|
Sorry about that, fixed the indentation. |
|
done and deployed and appears to be working nicely, changes may take a bit of time to show up in /release/ and a bit longer in the other directories, if anyone's impatient for forced updates I can give it a kick |
3 participants
Beginning in nodejs/node@537a4ba,
deps/uv/include/uv-version.hmoved todeps/uv/include/uv/version.h, so addthat as a possible path where libuv's version might be stored.
Refs: nodejs/node#21466
Unrelated note, but cc @Trott in case there are folks looking to get involved somewhere in Node, this is a low visibility with super high impact codebase (in JS) that could use some good refactoring. Happy to help mentor/review PRs if there are any takers...