Put Buffer polyfills in a list #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion here: https://github.com/nodejs/nodejs.org/pull/1666/files#r191602869 The idea is to give a more equal view of all the options. Removed the drawback about the number of dependencies of `buffer-from` and `buffer-alloc` since those 4 dependencies are smaller than the 1 `safer-buffer`.
ckotzbauer
reviewed
May 31, 2018
| A downside with this approach is slightly more code changes to migrate off them (as you would be | ||
| using e.g. `Buffer.from` under a different name). | ||
|
|
||
| - **[safe-buffer](https://www.npmjs.com/package/safe-buffer)** is also a drop in replacement for |
There was a problem hiding this comment.
Use "drop-in replacement" to be consistent with above spelling.
ckotzbauer
approved these changes
May 31, 2018
daxlab
reviewed
May 31, 2018
| You would take exactly the same steps as in [Variant 1](#variant-1), but with a polyfill | ||
| `const Buffer = require('safer-buffer').Buffer` in all files where you use the new `Buffer` API. | ||
|
|
||
| Make sure that you do not use old `new Buffer` API — in any files where the line above is added, |
There was a problem hiding this comment.
nit:
- in any file
- where above line is added
daxlab
reviewed
May 31, 2018
| - **[safe-buffer](https://www.npmjs.com/package/safe-buffer)** is also a drop in replacement for | ||
| the entire `Buffer` API, but using `new Buffer()` will still work as before. | ||
|
|
||
| A downside to this approach is that it will allow you to also use the older `new Buffer()` API |
Trott
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion here:
https://github.com/nodejs/nodejs.org/pull/1666/files#r191602869
The idea is to give a more equal view of all the options.
Removed the drawback about the number of dependencies of
buffer-fromandbuffer-allocsince those 4 dependencies are smaller than the 1safer-buffer.