Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 19, 2018

Finished all the translations in the folders.

@ghost ghost changed the title Translations of files in locale\zh-cn\docs [Localization] Translations of files in locale\zh-cn\docs Jun 19, 2018
@fhemberger
Copy link
Contributor

@Maledong Could you please mention the translation team for review in your future PRs (see below)?

/cc @nodejs/nodejs-cn

@ghost
Copy link
Author

ghost commented Jun 19, 2018

@fhemberger :Because I haven't finished all of them yet, I don't want to call them.
My submit is based on folders with all of the files there.
But anyway for pre-reviewing is also OK with me:)

@laosb
Copy link

laosb commented Jun 20, 2018

@Maledong : At least feel free to ping me alone when you finish a piece of doc, since in the l10n group no one are actually working full time reviewing PRs. It's better to "submit one, review one", at least for me I would put off reviewing a long multiple-file PR. (maybe forever before I visit that PR again)

@ghost
Copy link
Author

ghost commented Jun 22, 2018

@laosb : OK, I'll submit one by one if I have free time.
Thanks all!

Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish reviewing es6.md. And I've suggested you should avoid splitting Chinese paragraph into multiple lines to avoid extra spaces.

Btw, I'm having my final exams for this semester. I will be back reviewing you great PR after July 5.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing 此网站 sounds better. And please remember to do CW-spacing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你应该有对未来 Node.js 升级而造成代码破坏(无法正常工作)的准备,如果 V8 引擎做了更改,它的语义变得更接近标准的话。

你应该有对未来 Node.js 升级而造成代码破坏(无法正常工作)的准备,比如 V8 引擎做了更改,它的语法变得更接近标准。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting a Chinese paragraph to multiple lines would result in extra spaces between characters. Please put them to one line.

Copy link
Author

@ghost ghost Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using Visual Studio Code, and it seems I didn't split them into multiple lines……?

Plz have a view of https://github.com/Maledong/nodejs.org/blob/790f8d2ca03796de5347d5a53737708681b5887a/locale/zh-cn/docs/guides/anatomy-of-an-http-transaction.md.

This is just ONLY the show differences:)
请注意:VSC,GitHub预览页面显示的单行文本长度不同的。所以请直接看我给你的连接为准,谢谢!因为不同文本编辑器文本长度可以调节。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maledong it’s clear if you see line numbers ;) And actually you could see extra spaces in sentences, with the link you provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maledong This is a must-fix.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常建议

强烈建议

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK。这并不是自动换行。这是批注的GitHub自动预览时候产生效果。请对比:
default

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ghost
Copy link
Author

ghost commented Jun 25, 2018

@fhemberger : What does here one mean in buffer-constructor-deprecation.md? Is there anything missing here?

This is useful if you create Buffer instances in only a few places (**e.g. one**)

@fhemberger
Copy link
Contributor

@Maledong I guess it means if you just need one instance … 🤔

@ghost
Copy link
Author

ghost commented Jun 25, 2018

OK. I thought you were trying to write something but later you didn't continue doing that before submitting... OK. Thanks anyway!

BTW: My accout is somehow invalid by GitHub, so I removed my email accout and use a new one instead. So don't be feeling curious about why my icons are something like this following:

default

@ghost
Copy link
Author

ghost commented Jun 30, 2018

@laosb:I've finished all the translations in this folder. You can check them all if you have free time.

@laosb
Copy link

laosb commented Jul 4, 2018

@Maledong: Well done, I will start reviewing today since I finish all my exams this semester.

Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anatomy-of-an-http-transaction Reviewed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maledong This is a must-fix.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们同样假定你熟悉一些关于 Node.js 的东西 [EventEmitters][] 和 [Streams][]

我们同样假定你熟悉 Node.js 的 [EventEmitters][] 和 [Streams][]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文 Any node web server application will at some point have to create a web server object.

在此处 at some point 应当翻译为「总是」「总归」。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发出请求 =》 请求

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

创造 =》 构造函数

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll get to those shortly. 意为「我们马上会讲到。」

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

显示调用 =》 显式调用

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet 消息头 is widely known as "请求头"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

让我们简化之前代码来做一个可以简单有响应的服务端

让我们简化之前的代码,做一个可以有响应的简单的服务端

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们只对以下条件应答

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ghost ghost self-assigned this Jul 9, 2018
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, don't split into 2 lines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right on Line 2. It's better worded as 积压.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix all related translations

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本文的第二部分将给予你实现流的功能时最佳实践,以确保你的程序既安全又精简

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most cases we keep the originals of EventEmitter, Streams, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this is related to some node API or module function names, it shouldn't be translated. However if it's related to some explainations. I suggest translations needed. So I changed part of them.

@ghost ghost requested a review from willin July 16, 2018 03:53

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my infrastructure set up to leverage the --harmony flag. Should I remove it?
I think 'leverage' means '利用' in here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaSCript => JavaScript

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

依赖与

依赖于

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ghost ghost removed the request for review from willin July 19, 2018 02:53
@ghost
Copy link
Author

ghost commented Aug 1, 2018

It's been quite a long time……Anything left?

Copy link
Contributor

@willin willin Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments in codes should also be translated

Copy link
Author

@ghost ghost Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suggest that comments shouldn't be translated but to keep original.
No translate books will translate comments from one language to another, which is a default rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句是谷歌翻译的吗?

This may seem a tad tedious, and in many cases, it is. 

Luckily, there are modules like concat-stream and body on npm which can help hide away some of this logic. 

这看起来有些单调乏味,大多数情况下也确实是这样。不过庆幸的是,npm上有…… blabla

Copy link
Author

@ghost ghost Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's all translated by myself.
And I'll update according to what you said.

Copy link
Contributor

@willin willin Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param names should not be translated, or translate with comment notes.

Copy link
Author

@ghost ghost Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Sorry but I have to say that I disagree with you on the point.

Notice that this just emphises what we do in a verb——Here request and response is the verb of the whole sentence instead of a snippet of codes. If you translate this like '我们只能 request 到请求……'.——Where's the predicate in Chinese?

@ghost
Copy link
Author

ghost commented Aug 12, 2018

@laosb : Sorry to interrupt:Have you reviewed all of them?

@laosb
Copy link

laosb commented Aug 12, 2018

I'm terribly sorry for not continue to review this PR, it's quite a lot of work for me and I'm always have something other to do - so in general if you get 2 native language users' LGTM the pr should be good to enough for merging. I'm kind of perfectist so you don't have to wait for only me, go ahead if you won 1 more LGTM - Thank you for your kindly contribution!

@ghost
Copy link
Author

ghost commented Aug 25, 2018

Well……Since this has been lasting for quite a long time and it seems we have no time have a review again. After having a review by myself again I don't think it will cause a big problem. So I'll merge it and later we can fix the translation problem as well. Hope you all can understand.

@ghost ghost merged commit ceb5d09 into nodejs:master Aug 25, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants