Skip to content

Conversation

@ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Sep 10, 2018

Fix index in zh-cn when users click.

timers and poll should index to the suitable position.

@ghost
Copy link

ghost commented Sep 10, 2018

/cc: @nodejs/nodejs-cn

@ghost
Copy link

ghost commented Sep 10, 2018

@ZYSzys

I just feel curious to know that since in English version we don't have that symbol, and we need to be the same as the English version. Or do you think it's better? Or English version has missed this?

What about this suggestion? Any other suggestions?

@ghost ghost changed the title fix index in zh-cn zh-CN:Fix by adding index positions to some titles Sep 10, 2018
@ZYSzys
Copy link
Member Author

ZYSzys commented Sep 10, 2018

I think It should be the markdown syntax that indexing positions to some titles.

I've tried changing titles to Chinese but it didn't work indexing.
However it can be done by adding the symbol <!--[titles]-->

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 9908aa9 into nodejs:master Sep 14, 2018
@ghost
Copy link

ghost commented Sep 14, 2018

@ZYSzys: Thanks anyway!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants