guides: add ABI stability guide #1828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhdawson @gireeshpunathil @benjamingr I have moved the guide to this repo so it might appear on the Web site. Could you PTAL? |
This was referenced Oct 7, 2018
Trott
approved these changes
Oct 7, 2018
benjamingr
approved these changes
Oct 7, 2018
gireeshpunathil
approved these changes
Oct 7, 2018
vsemozhetbyt
approved these changes
Oct 7, 2018
|
@benjamingr thanks! |
gabrielschulhof
force-pushed
the
add-abi-stability-guide
branch
from
9467531 to
e98c3a5
Compare
|
Whoops! Forgot to add to |
lpinca
reviewed
Oct 7, 2018
gabrielschulhof
force-pushed
the
add-abi-stability-guide
branch
from
e98c3a5 to
af53983
Compare
|
@lpinca I have addressed your comments. |
lpinca
approved these changes
Oct 8, 2018
ghost
approved these changes
Oct 8, 2018
Trott
reviewed
Oct 8, 2018
gabrielschulhof
pushed a commit
that referenced
this pull request
Oct 9, 2018
PR-URL: #1828 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Milos Jevtovic <[email protected]>
|
Landed in 3214a8d. |
ghost
mentioned this pull request
stevemao
pushed a commit
that referenced
this pull request
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.