Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 26, 2018

  1. Missing the v8, v9 links of doc.
  2. Fix the site.json in fa, add rtl and locale attributes.

@ghost ghost requested a review from fhemberger October 26, 2018 23:11
@ghost ghost changed the title doc: Add the missing version of Nodejs 10.x doc: Add the missing versions of Nodejs APIs' links Oct 26, 2018
@ghost
Copy link
Author

ghost commented Oct 27, 2018

Notice: This can be postponed until Nodejs 8.x is retired from LTS in maintance state, because I've
added Nodejs 8.x as a previous version.

Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding v10 too ?

@ghost
Copy link
Author

ghost commented Oct 28, 2018

@ZYSzys

Good question!

Nodejs v10.X will be the active LTS since 2018-10-30 (See:https://github.com/nodejs/Release#release-schedule). So it shoudn't be a previous version in my mind.

But what confuses me is:Since 2018-10-30 v10 will take place of v8.X, will v8.X be the previous version? I have to put it there but as you know, v8 at that time is still in Active LTS……So how to cope with two versions of Nodejs (both v8 and v10 will be ACTIVE LTS after Oct 2018)?

together

@lpinca
Copy link
Member

lpinca commented Oct 28, 2018

Node.js 10 will be shown on the left side so it doesn't make sense to add it.

There will be 11 and 10 here:

screen shot 2018-10-28 at 11 19 18

@lpinca
Copy link
Member

lpinca commented Oct 28, 2018

@Maledong keep it as is. It's how it should be as soon as 10 will be tagged as LTS.

@ghost
Copy link
Author

ghost commented Oct 28, 2018

@lpinca:OK, So now I'll keep v8 in the previous list :)

1) Missing the v8, v9 links of doc.
2) Fix the site.json in `fa`, add `rtl` and `locale` attributes.
@ghost ghost requested review from Trott and Tsuna-mi October 30, 2018 05:55
@ghost
Copy link
Author

ghost commented Oct 30, 2018

Since the latest release of Nodejs 10.x has come. So I'll push this PR :)

new

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants