Skip to content

Stylus: always use variables for colors. #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Stylus: always use variables for colors. #2528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .stylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"expect": "never",
"error": true
},
"colors": false,
"colors": {
"expect": "always",
"error": true
},
"commaSpace": {
"expect": "always",
"error": true
Expand Down
2 changes: 1 addition & 1 deletion layouts/css/_base.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ a:hover
a:hover
code
background-color transparent
color #fff
color $white

a.imagelink
display inline-block
Expand Down
1 change: 1 addition & 0 deletions layouts/css/_variables.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ $light-gray2 = #ccc
$light-gray = #999
$gray = #666
$node-gray = #333
$nav-foundation-green = #026e00

padded-link($padding)
padding-left $padding
Expand Down
2 changes: 1 addition & 1 deletion layouts/css/page-modules/_header.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ header

// Special format for external 'Foundation' link in main navigation
.nav-foundation
background-color #026e00
background-color $nav-foundation-green

&:before
content none !important
Expand Down