Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 15, 2019

No description provided.

@SEWeiTung
Copy link
Contributor

@vasbaz, Maybe you should remove the last empty space for some sentences ;)
PS: You can use npm run test locally and resubmit your fixed changes.

@SEWeiTung
Copy link
Contributor

@nodejs/nodejs-ru, Please have a review of his translation except for the formation problem, thanks!

regular expressions, generating random salts, generating unique hashes from user
passwords, or inside the Express framework itself.
По выводу видно, что обрабатывается только около 5 запросов в секунду, а средний
запрос занимает чуть менее 4 секунд в оба конца. В реальной ситуации могло бы
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не "средний запрос", а "запрос в среднем"

@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 9, 2019

@vasbaz can you take care of @alexandrtovmach's comment and fix tests?

@Aissaoui-Ahmed
Copy link
Contributor

Aissaoui-Ahmed commented Oct 10, 2019

Remove the last spaces on the lines 126...130,133,134,145

See : CI -> Run tests

[htmllint] found 0 errors out of 30 files
locale/ru/docs/guides/simple-profiling.md: 126: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 127: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 128: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 129: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 130: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 133: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 134: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
locale/ru/docs/guides/simple-profiling.md: 145: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

@alexandrtovmach
Copy link
Contributor

@XhmikosR @Aissaoui-Ahmed
I think we need to close this PR or add staled label.

@XhmikosR
Copy link
Contributor

If you agree with the other changes, you can just apply the fixes and move forward.

@alexandrtovmach
Copy link
Contributor

I don't any changes here, just requested changes =)

@XhmikosR
Copy link
Contributor

@alexandrtovmach I mean this one

не "средний запрос", а "запрос в среднем"

I don't speak Russian, but if you want this change just edit the file :P

@alexandrtovmach
Copy link
Contributor

@XhmikosR Yeah, but also need to update lint issues... and here just a part of file translated

of a user request but even in our simple example, time could be lost compiling
regular expressions, generating random salts, generating unique hashes from user
passwords, or inside the Express framework itself.
По выводу видно, что обрабатывается только около 5 запросов в секунду, а средний
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
По выводу видно, что обрабатывается только около 5 запросов в секунду, а средний
По выводу видно, что обрабатывается только около 5 запросов в секунду, а запрос

regular expressions, generating random salts, generating unique hashes from user
passwords, or inside the Express framework itself.
По выводу видно, что обрабатывается только около 5 запросов в секунду, а средний
запрос занимает чуть менее 4 секунд в оба конца. В реальной ситуации могло бы
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
запрос занимает чуть менее 4 секунд в оба конца. В реальной ситуации могло бы
в среднем занимает чуть менее 4 секунд в оба конца. В реальной ситуации могло бы

understanding of the performance of your Node.js applications.

[profiler inside V8]: https://v8.dev/docs/profile
[профайлер V8]: https://v8.dev/docs/profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

потому что ссылка не будет работать

Suggested change
[профайлер V8]: https://v8.dev/docs/profile
[profiler inside V8]: https://v8.dev/docs/profile

@XhmikosR
Copy link
Contributor

That's OK I trimmed the whitespaces.

@alexandrtovmach alexandrtovmach merged commit 9136d5e into nodejs:master Oct 10, 2019
@alexandrtovmach
Copy link
Contributor

I'll update file by my own

@ghost ghost deleted the patch-1 branch December 23, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants