Skip to content

Make position of "Edit on GitHub" link consistent #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2016
Merged

Make position of "Edit on GitHub" link consistent #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d6435b
Make position of "Edit on GitHub" link consistent
strawbrary Jan 5, 2016
41310af
Move GitHub edit link outside header for SEO/a11y
strawbrary Jan 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ function githubLinks (options) {
var url = 'https://github.com/nodejs/nodejs.org/edit/master/locale/' + options.locale + '/' + path.replace('.html', '.md')

var contents = file.contents.toString().replace(/\<h1\>(.+)\<\/h1\>/, function ($1, $2) {
return '<h1>' + $2 + ' <a class="edit-link" href="' + url + '">Edit on GitHub</a></h1>'
return `<a class="edit-link" href="${url}">Edit on GitHub</a> <h1>${$2}</h1>`
})

file.contents = new Buffer(contents)
Expand Down
2 changes: 1 addition & 1 deletion layouts/css/base.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ pre

.edit-link
float right
font-size 0.6em
font-size 0.9em
margin 0.5em 0

@media screen and (max-width: 480px)
Expand Down