chore: node_env as global env #5613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
Unit Test Coverage Report
Unit Test Report
|
|
@styfle do you have any idea why Windows builds are failing saying that "npm" is not a recognised command? Never seen this (https://github.com/nodejs/nodejs.org/actions/runs/5802085672/job/15727733041?pr=5613) could that be due to strict env? |
styfle
reviewed
Aug 8, 2023
Co-authored-by: Steven <[email protected]> Signed-off-by: Claudio Wunder <[email protected]>
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
cc @nodejs/website I'm fast-tracking this as we're overusing a lot of Edge Middleware Invocations on our Vercel Cloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes our dynamic implementation of Middlewares, as discussed on #5604, since it is a Next.js limitation to support dynamic matchers and to reduce the number of invocations on our Edge Middleware.
Validation
This is validated by the Documentation of Next.js and after validating the indeed the amount of Edge Middleware invocations reduces.