chore: add static builds to ci to ensure static builds are still working #5617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
Member
Author
|
Failing on Windows due to: vercel/next.js#51225 |
bmuenzenmeyer
approved these changes
Aug 9, 2023
UlisesGascon
approved these changes
Aug 9, 2023
araujogui
approved these changes
Aug 9, 2023
aymen94
approved these changes
Aug 10, 2023
1 task
ovflowd
force-pushed
the
chore/add-static-builds-to-ci
branch
from
d83cfeb to
0c1e079
Compare
Contributor
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 10, 2023
This normalizes the backslash for windows users who accidentally use `\` in the request paths instead of the expected `/`. For example, in nodejs/nodejs.org#5617 the slash was hardcoded for split that caused the backlash to remain the the `getStaticPaths()` result. - Fixes #51225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply adds
staticbuilds in addition of our regular minimal buids, to ensure that all pages are building correctly at build time and that static builds still work regardless of the changes we're doingValidation
The current PR checks should pass