Skip to content

Conversation

beny996
Copy link
Contributor

@beny996 beny996 commented Apr 9, 2024

Description

Added Serbian localization to the i18n/config.json.

Validation

Related Issues

No related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@beny996 beny996 requested a review from a team as a code owner April 9, 2024 09:35
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 1:09pm

@beny996 beny996 changed the title chore: Added serbian language config chore: Add serbian language config Apr 9, 2024
@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Jun 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.363s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 15, 2024
@bmuenzenmeyer bmuenzenmeyer removed this pull request from the merge queue due to a manual request Jun 15, 2024
@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 15, 2024

@beny996 We need more information here.

Is this Cyrillic or Latin?

image

I suspect we might need to update https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L15-L20

@beny996
Copy link
Contributor Author

beny996 commented Jul 1, 2024

@bmuenzenmeyer It is latin. Sorry for the delay.

@bmuenzenmeyer
Copy link
Collaborator

Serbian (latin) added in crowdin

@bmuenzenmeyer
Copy link
Collaborator

This PR will need to be rebased or recreated now that #6850 merged.

@beny996
Copy link
Contributor Author

beny996 commented Jul 12, 2024

I will recreate the PR. @bmuenzenmeyer

@beny996 beny996 closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants