Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented Jun 9, 2024

Description

Adds back the content as a "community" blog post
Adds a redirect from the old location to the new

any bikeshedding on approach is fine with me

Validation

[OLD URL] https://nodejs-org-git-6823-domain-post-mortem-openjs.vercel.app/en/docs/guides/domain-postmortem
will bring you to
[NEW URL] https://nodejs-org-git-6823-domain-post-mortem-openjs.vercel.app/en/blog/community/domain-postmortem

Related Issues

fixes #6823
fixes tc39/proposal-async-context#92

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested review from a team as code owners June 9, 2024 20:40
@vercel
Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 9, 2024 8:40pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 76 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.163s ⏱️

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In the preview build, I was able to access this page to redirect, direct link, or listing page

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can fast-track this!

@bmuenzenmeyer bmuenzenmeyer added the fast-track Fast Tracking PRs label Jun 9, 2024
@bmuenzenmeyer
Copy link
Contributor Author

fast-tracking as a content/bug fix

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 9, 2024
@ovflowd ovflowd enabled auto-merge June 9, 2024 23:44
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 9, 2024
@ovflowd ovflowd added this pull request to the merge queue Jun 9, 2024
Merged via the queue into main with commit 6cdcbbc Jun 9, 2024
@ovflowd ovflowd deleted the 6823-domain-post-mortem branch June 9, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore/add a redirect for the domain postmorten pgae Link to Node's "Domain Module Postmortem" is 404

4 participants