Skip to content

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 30, 2025

Description

nodejs/node#58084

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Antoine du Hamel <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 12:01
@aduh95 aduh95 requested a review from a team as a code owner April 30, 2025 12:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/site.json: Language not supported

Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 30, 2025 0:02am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (91a533f) to head (8b2b7cd).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7689      +/-   ##
==========================================
+ Coverage   74.80%   74.81%   +0.01%     
==========================================
  Files          98       98              
  Lines        7878     7878              
  Branches      199      199              
==========================================
+ Hits         5893     5894       +1     
+ Misses       1984     1983       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 30, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 68 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd
Copy link
Member

ovflowd commented Apr 30, 2025

@nodejs/nodejs-website requesting fast tracking of this PR ✨

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Apr 30, 2025
@araujogui araujogui added the github_actions:pull-request Trigger Pull Request Checks label Apr 30, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 30, 2025
@araujogui araujogui added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 454d31d Apr 30, 2025
27 checks passed
@araujogui araujogui deleted the 18-eol branch April 30, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants