-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(css): consistent :hover
styles
#8036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(css): consistent :hover
styles
#8036
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes a visual inconsistency in the hover styling for sidebar items by adjusting the dark mode background color from dark:bg-neutral-800
to dark:bg-neutral-900
to ensure consistent hover effects.
- Updates dark mode hover background color for sidebar items to achieve visual consistency
Hi @avivkeller 👋, This PR addresses the hover styling inconsistency mentioned in #8034.
Let me know if any changes are needed. |
@@ -19,7 +19,7 @@ | |||
@apply rounded-sm | |||
bg-neutral-100 | |||
text-neutral-900 | |||
dark:bg-neutral-800 | |||
dark:bg-neutral-900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment showing the source of the other hover effect, so we know these are linked for the future?
:hover
styles
Hi @avivkeller, I've added the comment linking the hover style as requested. Please take a look when you have a moment. |
/* | ||
This ensures a consistent hover effect across the website in dark mode (bg-neutral-900) and light mode (bg-neutral-100). | ||
See: | ||
- src/Containers/NavBar/index.module.css (Navbar hover) | ||
- src/Containers/NavBar/NavItem/index.module.css (Footer hover) | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* | |
This ensures a consistent hover effect across the website in dark mode (bg-neutral-900) and light mode (bg-neutral-100). | |
See: | |
- src/Containers/NavBar/index.module.css (Navbar hover) | |
- src/Containers/NavBar/NavItem/index.module.css (Footer hover) | |
*/ | |
/* @see https://github.com/nodejs/nodejs.org/blob/main/packages/ui-components/src/Containers/NavBar/NavItem/index.module.css#L24 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will fix it.
Hi @avivkeller, |
Description
This pull request addresses a visual inconsistency in the hover styling and resolve issue : #8034
Validation
consistent-hover.mp4
Related Issues
Fixes #8034
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.