Skip to content

fix(css): consistent :hover styles #8036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mohit5Upadhyay
Copy link
Contributor

Description

This pull request addresses a visual inconsistency in the hover styling and resolve issue : #8034

Validation

consistent-hover.mp4

Related Issues

Fixes #8034

Check List

  • [✅] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [✅] I have run pnpm format to ensure the code follows the style guide.
  • [✅] I have run pnpm test to check if all tests are passing.
  • [✅] I have run pnpm build to check if the website builds without errors.
  • [✅] I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings July 26, 2025 07:46
@Mohit5Upadhyay Mohit5Upadhyay requested a review from a team as a code owner July 26, 2025 07:46
Copy link

vercel bot commented Jul 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 26, 2025 3:42pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a visual inconsistency in the hover styling for sidebar items by adjusting the dark mode background color from dark:bg-neutral-800 to dark:bg-neutral-900 to ensure consistent hover effects.

  • Updates dark mode hover background color for sidebar items to achieve visual consistency

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @avivkeller 👋,

This PR addresses the hover styling inconsistency mentioned in #8034.

&:not(.progression) .label {
      @apply rounded-sm
          ....
        // previously 
         dark:bg-neutral-800

        // updated
        dark:bg-neutral-900
          ....
    }

Let me know if any changes are needed.
Thanks for reviewing! 🙌

@@ -19,7 +19,7 @@
@apply rounded-sm
bg-neutral-100
text-neutral-900
dark:bg-neutral-800
dark:bg-neutral-900
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment showing the source of the other hover effect, so we know these are linked for the future?

@avivkeller avivkeller changed the title fix: implementing consistent :hover styling (#8034) fix(css): consistent :hover styles Jul 26, 2025
@Mohit5Upadhyay
Copy link
Contributor Author

Hi @avivkeller,

I've added the comment linking the hover style as requested. Please take a look when you have a moment.
Thanks again! 🙌

Comment on lines 19 to 24
/*
This ensures a consistent hover effect across the website in dark mode (bg-neutral-900) and light mode (bg-neutral-100).
See:
- src/Containers/NavBar/index.module.css (Navbar hover)
- src/Containers/NavBar/NavItem/index.module.css (Footer hover)
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/*
This ensures a consistent hover effect across the website in dark mode (bg-neutral-900) and light mode (bg-neutral-100).
See:
- src/Containers/NavBar/index.module.css (Navbar hover)
- src/Containers/NavBar/NavItem/index.module.css (Footer hover)
*/
/* @see https://github.com/nodejs/nodejs.org/blob/main/packages/ui-components/src/Containers/NavBar/NavItem/index.module.css#L24 */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will fix it.

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @avivkeller,
I've added the @see reference as suggested.
Let me know if any further adjustments are needed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:hover styling should be consistent
2 participants