Skip to content

Conversation

@ghaiklor
Copy link
Contributor

@ghaiklor ghaiklor commented Aug 1, 2016

Thanks to @denysdovhan we have Ukrainian language for NodeJS website.
/cc @nodejs/nodejs-uk

@Fishrock123 Fishrock123 added i18n Issues/PRs related to the Website Internationalisation needs WG +1 labels Aug 1, 2016
@Fishrock123
Copy link
Contributor

also cc @nodejs/website -- I don't think some of the pages here are necessary anymore and can probably also be removed from the english version, e.g. /advisory-board/.

@listochkin
Copy link

Adding +1 as a @nodejs/nodejs-uk member.

@ghost
Copy link

ghost commented Aug 2, 2016

@Fishrock123 yeah, we can definitely remove advisory-board and translations. i'll open a separate issue for that

otherwise, LGTM from me ✨

@ghost
Copy link

ghost commented Aug 2, 2016

@nodejs/nodejs-uk do you need one more LGTM from your group or can i merge this?

@sejoker
Copy link

sejoker commented Aug 3, 2016

One more LGTM from me as a @nodejs/nodejs-uk member.

@denysdovhan
Copy link
Contributor

@lac this translation is already checked by Ukrainian philologist, so we sure that everything is OK.

@fhemberger fhemberger merged commit ede45e5 into nodejs:master Aug 3, 2016
@fhemberger
Copy link
Contributor

Thank you!

@phillipj
Copy link
Member

phillipj commented Aug 3, 2016

Very nice work! 👍

P.S. when new locales gets added, atm we have to manually enable english fallback (#490, nodejs/build#316) in the nginx config as done in nodejs/build#458.

@denysdovhan
Copy link
Contributor

I've noticed a few small mistakes on the website. Gonna send pr with fixes.

And it seems like font doesn't support cyrillic characters and therefore it brakes layout. Take a look at nodejs/nodejs-uk#88.

@ghaiklor ghaiklor deleted the locale/uk branch August 4, 2016 06:05
jbergstroem pushed a commit to nodejs/build that referenced this pull request Aug 8, 2016
jbergstroem pushed a commit to nodejs/build that referenced this pull request Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants