Skip to content

add Node as prohibited string in favor of Node.js #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

add Node as prohibited string in favor of Node.js #35

merged 1 commit into from
Dec 4, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 2, 2019

@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

The test failures are addressed in nodejs/node#30758.

@Trott Trott merged commit d1c80fe into nodejs:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschonni nschonni nschonni approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott @nschonni @richardlau