Skip to content

Conversation

Moon-DaeSeung
Copy link
Contributor

Description of Changes

Here is reference: #25


support 'custom your created block' block

  • some css is conflicted on bullet-list-item, numbered-list-item

Review point

  • ex) I narrow css selector on notion-list-marker

To reproduce

  • npm run story:start
  • click 'your created block' on the Storybook left side panel

Screenshot

  • A screenshot of your created block being rendered in Storybook.

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@myjeong19
Copy link
Member

LGTM!!!!

@myjeong19 myjeong19 merged commit 0a140e4 into main Sep 28, 2024
@myjeong19 myjeong19 deleted the fix/css-conflict-on-list-imte branch September 28, 2024 00:49
Copy link
Member

@myjeong19 myjeong19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants