Skip to content

Conversation

Moon-DaeSeung
Copy link
Contributor

Description of Changes

Here is reference: #25


support 'code' block

  • I support java, js, kotlin, exliar etc..

Review point

To reproduce

  • npm run story:start
  • click 'your created block' on the Storybook left side panel

Screenshot

image

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@Moon-DaeSeung Moon-DaeSeung added the enhancement New feature or request label Oct 1, 2024
@myjeong19
Copy link
Member

Thank you very much for your contribution. It's an excellent code block. However, there are two issues:

P1. In the code folder's index part, there is an unused children prop. Is there a particular reason for this?
P2. In the markdown section, the createInline(/(~~?)(?:(?!~))+\2/.source) part has an error.
I believe it should be corrected from \2/ to \/2/.

@Moon-DaeSeung
Copy link
Contributor Author

@myjeong19 I fix it. please check this

Copy link
Member

@myjeong19 myjeong19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOOD!

@Moon-DaeSeung Moon-DaeSeung merged commit 102b8ea into main Oct 3, 2024
@anonymousRecords anonymousRecords linked an issue Oct 7, 2024 that may be closed by this pull request
@Moon-DaeSeung Moon-DaeSeung deleted the feat/code branch October 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Notion Block] Support Code notion block

2 participants