Skip to content

Conversation

anonymousRecords
Copy link
Member

Description of Changes

Here is reference: #25


support 'custom your created block' block

  • Please add the block you created to replace the 'crate' block.

  • ex) add react-katex dependency to support equation block
    -> add custom solution for rendering 'your custom block'

Review point

  • ex) Instead of adding the react-katex dependency, should I create a custom solution specifically for this project?
    -> Should we integrate an existing solution or use a custom implementation for 'your custom block'?

To reproduce

  • npm run story:start
  • click 'your created block' on the Storybook left side panel

Screenshot

  • A screenshot of your created block being rendered in Storybook.

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@Moon-DaeSeung
Copy link
Contributor

##KR
와우 퀄리티가 장난 아닌데요?? 좋습니다 ㅎㅎㅎ

##EN
you are good!

@Moon-DaeSeung Moon-DaeSeung added the documentation Improvements or additions to documentation label Oct 6, 2024
@Moon-DaeSeung Moon-DaeSeung marked this pull request as ready for review October 6, 2024 14:20
@Moon-DaeSeung Moon-DaeSeung merged commit 39e4939 into notionpresso:docs/init-start-guide Oct 6, 2024
Moon-DaeSeung added a commit that referenced this pull request Oct 20, 2024
* init

* docs 수정

* good

* chore

* add docs on english

* [Draft] react-custom-notion official document (#57)

* feat: Implement layout

* feat: Implement theme-provider

* feat: Implement Navigation

* feat: Implement Guide Documentation page

* fix: modify theme modes

* feat: implement toc components

* fix: close language selector when clicking anywhere

* style: add logo animation effect

* feat: implement navigation button

* refactore: add metadata

* feat: implement home page

* feat: support mobile size

* refactor: modify navigation-button

* feat: add redirect (/ -> /en)

* refacter: implement toc

* chore: delete unused dependencies

* chore: add English translation

---------

Co-authored-by: Serim Min <[email protected]>
Co-authored-by: anonymousrecords <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants