Isaacs/doctor #1638
Closed
Isaacs/doctor #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/doctor
branch
2 times, most recently
from
e1eec07 to
310194f
Compare
ruyadorno
reviewed
Aug 7, 2020
| To report bugs or submit feature requests for the docs, or for any | ||
| issues regarding the npm command line tool, please post <a | ||
| href='https://github.com/npm/cli/issues'>on the npm/cli GitHub | ||
| project</a>. |
There was a problem hiding this comment.
oh, we should def backport this to v6 too 😊
Pending unit tests still, but at least it works to a rough approximation now, instead of not working at all.
ruyadorno
pushed a commit
that referenced
this pull request
Aug 7, 2020
PR-URL: #1638 Credit: @isaacs Close: #1638 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on update-notifier refactor branch, land that first.