fix: json-parse-even-better-errors dep listing #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
added
Release 7.x
ljharb
approved these changes
Jan 28, 2021
nlf
approved these changes
Jan 28, 2021
Currently `json-parse-even-better-errors` is listed as a dev dependency but that's currently used in a few places such as `lib/set-script.js` and `lib/view.js`. Thanks: @XhmikosR PR-URL: npm#2564 Credit: @ruyadorno Close: npm#2564 Reviewed-by: @nlf
nlf
force-pushed
the
fix-json-parse-even-better-errors-dep-listing
branch
from
9d23d34 to
bb7329d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
json-parse-even-better-errorsis listed as a dev dependencybut that's currently used in a few places such as
lib/set-script.jsand
lib/view.js.Thanks: @XhmikosR