Skip to content

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Mar 10, 2021

at a glance, these do not appear necessary to ship with the tarball and don't really make sense for most end users.

these changes reduce the published tarball by ~300kb and the installed size by ~1mb

References

@nlf nlf requested a review from a team as a code owner March 10, 2021 20:50
@ruyadorno
Copy link
Contributor

I'd like to give it a try at our release integration with nodejs to make sure it doesn't prune any of the expected files there, for instance .eslintrc.json looks like it's pb going to be required for tests to run there, it's fine if we want to tweak it but let's make sure it doesn't break that workflow 😊

@nlf
Copy link
Contributor Author

nlf commented Mar 11, 2021

the node release integration clones this repo, it doesn't use the tarball. It can't since the tarball doesn't include the tests themselves either

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Mar 11, 2021
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

.mailmap
changelogs/*
configure
make.bat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to check to make sure that the install.sh isn't calling ./configure or make, but these are fine to leave out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants