Skip to content

Conversation

jumoel
Copy link
Contributor

@jumoel jumoel commented Jul 1, 2022

What

Add the ability to deprecate single values for options, instead of just whole options.

Why

Allows for instance the --auth-type configuration option to have non-deprecated as well as deprecated values.

References

@jumoel jumoel force-pushed the jumoel/deprecated-values branch from ee841d3 to 67d762a Compare July 1, 2022 10:02
@jumoel jumoel changed the title [WIP] feat: Add ability to deprecate single values [WIP] chore: Deprecate singular auth-type config values Jul 1, 2022
@jumoel jumoel force-pushed the jumoel/deprecated-values branch from 67d762a to 7e3eb23 Compare July 1, 2022 10:15
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jul 1, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.158 ±3.17 16.021 ±0.06 14.090 ±0.03 16.470 ±0.67 2.513 ±0.01 2.510 ±0.02 2.073 ±0.06 9.789 ±0.05 2.007 ±0.01 3.216 ±0.34
#5115 33.336 ±2.73 15.994 ±0.07 14.192 ±0.08 16.931 ±0.88 2.535 ±0.05 2.518 ±0.01 2.063 ±0.01 9.843 ±0.05 2.033 ±0.02 3.118 ±0.21
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 22.438 ±0.47 11.959 ±0.05 10.715 ±0.10 11.572 ±0.58 2.373 ±0.01 2.316 ±0.00 2.062 ±0.01 7.186 ±0.00 1.962 ±0.00 2.682 ±0.02
#5115 24.455 ±0.18 12.034 ±0.12 10.599 ±0.10 11.629 ±0.23 2.334 ±0.01 2.320 ±0.01 2.049 ±0.00 7.308 ±0.20 1.951 ±0.02 2.730 ±0.03

@wraithgar
Copy link
Member

Superceded by #5149

@wraithgar wraithgar closed this Jul 12, 2022
@wraithgar wraithgar deleted the jumoel/deprecated-values branch July 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants