fix: remove unnecessary package.json values #6555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/bin-cleanup
branch
from
67aeffb to
2145820
Compare
lukekarrys
force-pushed
the
lk/pkg-cleanup
branch
3 times, most recently
from
5d2330f to
1ae5f61
Compare
lukekarrys
force-pushed
the
lk/bin-cleanup
branch
from
2145820 to
fbfd2ca
Compare
lukekarrys
force-pushed
the
lk/pkg-cleanup
branch
from
1ae5f61 to
990485d
Compare
This removes `directories.bin` from npm's `package.json` since it instead uses the `bin` object syntax to create the bins for `npm` and `npx`. The non-JS files in that directory are used by the Node installer, and are not actually bin files that npm is responsible for linking. This also does a few items of cleanup around those `bin/` files: - Removes the unused `node-gyp-bin` files. Those are remnants from before `@npmcli/run-script` was introduced in `npm@7`. Now that package is responsible for setting `PATH` with the appropriate `node-gyp` bin. - Fixes an issue in `bin/npx` where the exit code was not being read from the `npx prefix` call. - Test the contents of the `bin/(npm|npx)(.cmd)?` files to ensure the only differences between them are `npm -> npx`
lukekarrys
force-pushed
the
lk/bin-cleanup
branch
from
fbfd2ca to
62b65d3
Compare
lukekarrys
force-pushed
the
lk/pkg-cleanup
branch
2 times, most recently
from
05aee06 to
c3160cf
Compare
lukekarrys
force-pushed
the
lk/pkg-cleanup
branch
from
c3160cf to
df0d64f
Compare
wraithgar
reviewed
Jun 14, 2023
wraithgar
approved these changes
Jun 14, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.