chore: use proxy instead of http-proxy #6814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/smoke-test-proxy
branch
3 times, most recently
from
912beee to
f8778e1
Compare
The proxy package is more spec compliant and works out-of-the-box so we no longer have to pass --registry=PROXY to the tests. The goal here is to make it simpler to help debug #6793.
lukekarrys
force-pushed
the
lk/smoke-test-proxy
branch
from
b431ecc to
11f314d
Compare
|
This is now at least less flaky than it was before. I just reran the actions twice in a row with no failures. I think adding |
wraithgar
approved these changes
Sep 20, 2023
lukekarrys
added a commit
that referenced
this pull request
Oct 6, 2023
The proxy package is more spec compliant and works out-of-the-box so we no longer have to pass --registry=PROXY to the tests. The goal here is to make it simpler to help debug #6793.
lukekarrys
added a commit
that referenced
this pull request
Oct 6, 2023
The proxy package is more spec compliant and works out-of-the-box so we no longer have to pass --registry=PROXY to the tests. The goal here is to make it simpler to help debug #6793.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.
The goal here is to make it simpler to help debug #6793.