util.stripVTControlCharacters #7157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wraithgar
commented
Jan 18, 2024
wraithgar
commented
- deps: remove strip-ansi
- fix: use util.stripVTControlCharacters instead of strip-ansi
Only removes from direct dependencies, is still a non-dev subdependency
wraithgar
force-pushed
the
gar/stripvt
branch
from
35ce479 to
0aae547
Compare
fritzy
approved these changes
Jan 19, 2024
| @@ -1,5 +1,6 @@ | |||
| const os = require('os') | |||
| const { resolve } = require('path') | |||
| const os = require('node:os') | |||
There was a problem hiding this comment.
Is there a plan to update all node modules require statements with the prefix?
There was a problem hiding this comment.
So far no, just updating as we go.
|
Is there a ticket associated to this PR? Where can I find more context about this change? |
|
No there is no ticket. It was just a clean up / follow up based on learning about that method when doing #7113 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.