-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: don't suggest npm update outside of valid engine range #8050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We'll want a new test for the behavior this is guarding against. |
|
while thinking on how to write a test for this one, logically the problem this pr solves it to get correct engine matched version, we only request for |
Yes, this is behavior we don't want to accidentally regress from. The update notifier tests will likely need a bit of tweaking to get there |
f95e421 to
07fd64f
Compare
ee70630 to
a1f0923
Compare
c4d1ace to
8936f66
Compare
8936f66 to
bf1ea3d
Compare
When doing manifest call for fetching npm manifest it was using latest every-time, however fetching
npm@*will still givelatestif it's satisfies the engine range otherwise it will give highest matching version for the current engine range.Pacote.manifest calls internally uses pick-manifest logic to pick the appropriate version of the manifest for the engine range.