fix: handle missing time in packument to prevent crash on npm view
#8241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlstronaut
force-pushed
the
owlstronaut/fix-view-crash
branch
from
b4ae395 to
ebecc1d
Compare
owlstronaut
changed the title
time in packument to prevent crash on npm viewtime in packument to prevent crash on npm view
wraithgar
reviewed
Apr 18, 2025
owlstronaut
force-pushed
the
owlstronaut/fix-view-crash
branch
from
ebecc1d to
b48c40a
Compare
wraithgar
approved these changes
Apr 21, 2025
|
Test failures are cause the source branch is behind by one commit. Tests for this PR are ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8132
Before & After
Validated that tests start throwing errors without the fix ✅