Skip to content

Conversation

@wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 4, 2021

BREAKING CHANGE: this drops support for eslint@7
Our testing matrix is where we ensure we are working in the environments
we need. The linter is not what should be slowing us down with what
features we write.

@wraithgar wraithgar requested a review from a team as a code owner November 4, 2021 22:08
BREAKING CHANGE: this drops support for eslint@7
Our testing matrix is where we ensure we are working in the environments
we need. The linter is not what should be slowing us down with what
features we write.
@lukekarrys
Copy link
Contributor

Not a blocker but I wanted to point out that node/process-exit-as-throw is currently broken with eslint@8: mysticatea/eslint-plugin-node#301

I think we should manually disable any cases that break because of this with a comment to revisit when that issue is fixed.

@wraithgar
Copy link
Member Author

Well hopefully process.exit() isn't in any of our hot paths outside of things like the helper bins that ship with things like pacote or arborist. Seems like a good place to double check that the code looks right anyways, and the cli itself is the only process.exit() that we really need to be super prescriptive about.

@wraithgar wraithgar merged commit 41ec96d into main Nov 8, 2021
@wraithgar wraithgar deleted the gar/es2022 branch November 8, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants