Skip to content

fix: ensure SemVer instance passed to inc are not modified #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: ensure SemVer instance passed to inc are not modified #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
615b581
test(inc): ensure SemVer instanced passed as input are not modified
louis-bompart Apr 10, 2022
fd67a71
fix(inc): ensure SemVer instanced passed as input are not modified
louis-bompart Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion functions/inc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ const inc = (version, release, options, identifier) => {
}

try {
return new SemVer(version, options).inc(release, identifier).version
return new SemVer(
version instanceof SemVer ? version.version : version,
options
).inc(release, identifier).version
} catch (er) {
return null
}
Expand Down
10 changes: 10 additions & 0 deletions test/functions/inc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,20 @@ test('increment versions test', (t) => {
t.equal(found, wanted, `${cmd} === ${wanted}`)

const parsed = parse(pre, options)
const parsedAsInput = parse(pre, options)
if (wanted) {
parsed.inc(what, id)
t.equal(parsed.version, wanted, `${cmd} object version updated`)
t.equal(parsed.raw, wanted, `${cmd} object raw field updated`)

const preIncObject = JSON.stringify(parsedAsInput)
inc(parsedAsInput, what, options, id)
const postIncObject = JSON.stringify(parsedAsInput)
t.equal(
postIncObject,
preIncObject,
`${cmd} didn't modify its input`
)
} else if (parsed) {
t.throws(() => {
parsed.inc(what, id)
Expand Down