Skip to content

fix(bin): get correct value from arg separated by equals #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2022
Merged

fix(bin): get correct value from arg separated by equals #449

merged 1 commit into from
Apr 10, 2022

Conversation

lukekarrys
Copy link
Contributor

Fixes #431

@lukekarrys lukekarrys requested a review from a team as a code owner April 10, 2022 00:25
ljharb
ljharb approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@lukekarrys lukekarrys merged commit 4ceca76 into main Apr 10, 2022
@lukekarrys lukekarrys deleted the lk/bin-equals branch April 10, 2022 02:48
@github-actions github-actions bot mentioned this pull request Apr 10, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ljharb ljharb ljharb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] bin doesnt work when incrementing arg with equals sign

2 participants

@lukekarrys @ljharb