-
Notifications
You must be signed in to change notification settings - Fork 248
RFC: Add --query to npm audit
#636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--query to npm audit--audit-query to npm audit
ljharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is just a filter on whatever npm audit is doing? If so, sounds great - it would presumably be settable in .npmrc, so the default audit done on install could be changed?
|
@darcyclarke the PR title mentions the name of |
--audit-query to npm audit--query to npm audit
|
@ruyadorno updated the title. I'm easy with the flag name tbh but am leaning toward the un-prefixed |
Co-authored-by: Jordan Harband <[email protected]>
|
@ljharb essentially, yes. In previous RFC discussions I've used the term "Audit Filters" a lot but it's really just ensuring we can passing around a query selector to define the set of dependencies we want to actually execute the action against. |
|
As a generic means to filter whatever audit action happens to be being run, this makes perfect sense. |
Rendered RFC