Skip to content

fix: dont conclude checks if they were never set #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

fix: dont conclude checks if they were never set #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
run: npm run postlint --ignore-scripts -ws -iwr --if-present
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
run: npm test --ignore-scripts -ws -iwr --if-present
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
Expand Down
4 changes: 2 additions & 2 deletions lib/content/ci-release-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
{{> stepLintYml jobRunFlags=allFlags }}
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
Expand All @@ -42,7 +42,7 @@ jobs:
{{> stepTestYml jobRunFlags=allFlags }}
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
Expand Down
12 changes: 6 additions & 6 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ jobs:
run: npm run postlint --ignore-scripts
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: \${{ secrets.GITHUB_TOKEN }}
conclusion: \${{ job.status }}
Expand Down Expand Up @@ -521,7 +521,7 @@ jobs:
run: npm test --ignore-scripts
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: \${{ secrets.GITHUB_TOKEN }}
conclusion: \${{ job.status }}
Expand Down Expand Up @@ -2100,7 +2100,7 @@ jobs:
run: npm run postlint --ignore-scripts -ws -iwr --if-present
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: \${{ secrets.GITHUB_TOKEN }}
conclusion: \${{ job.status }}
Expand Down Expand Up @@ -2169,7 +2169,7 @@ jobs:
run: npm test --ignore-scripts -ws -iwr --if-present
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: \${{ secrets.GITHUB_TOKEN }}
conclusion: \${{ job.status }}
Expand Down Expand Up @@ -3771,7 +3771,7 @@ jobs:
run: npm run postlint --ignore-scripts -ws -iwr --if-present
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: \${{ secrets.GITHUB_TOKEN }}
conclusion: \${{ job.status }}
Expand Down Expand Up @@ -3840,7 +3840,7 @@ jobs:
run: npm test --ignore-scripts -ws -iwr --if-present
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: always()
if: steps.create-check.outputs.check-id && always()
with:
token: \${{ secrets.GITHUB_TOKEN }}
conclusion: \${{ job.status }}
Expand Down