fix: scoped names validate exclusionlist/underscore/core module #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We'll have to dig into this on the registry side but we may just have to allow these. I know builtins especially should be allowed cause that's the whole point of scoped packages. |
owlstronaut
force-pushed
the
scoped-name-validation
branch
from
9006ddf to
fee6521
Compare
owlstronaut
force-pushed
the
scoped-name-validation
branch
from
fee6521 to
f072c2a
Compare
wraithgar
changed the title
wraithgar
approved these changes
Jul 21, 2025
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Jul 21, 2025
🤖 I have created a release *beep* *boop* --- ## [6.0.2](v6.0.1...v6.0.2) (2025-07-21) ### Bug Fixes * [`186f541`](186f541) [#142](#142) scoped names validate exclusionlist/underscore/core module (#142) (@owlstronaut) ### Chores * [`8123f73`](8123f73) [#140](#140) bump @npmcli/template-oss from 4.24.4 to 4.25.0 (#140) (@dependabot[bot], @owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates terminology for clarity and inclusivity, modifies validation logic, and enhances test coverage for the
validate-npm-package-namemodule. The most important changes include renaming to exclusion list, updating error messages, and adding new test cases for scoped package validation.