fix(#518): guard cookie writes when response headers already sent #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR implements a defensive guard for SSR cookie writes.
Previously,
setAllunconditionally attempted to callsetCookieeven when the H3/Node response headers had already been sent. This caused runtime errors and unhandledRejection spam during token refresh in dev after idle:The fix introduces a
headersWritablecheck in bothruntime/plugins/supabase.server.jsandruntime/server/services/serverSupabaseClient.js.If headers are already sent or the response has ended, cookie writes are skipped.
This prevents crashes and log spam without altering normal behavior when headers are writable.
Resolves: #518
Checklist